Seite 1 von 1

Ex 7 Grading Lowest Within One Month

Verfasst: 9. Jan 2018 13:01
von Stefan94
Hey,

regarding the task lowestWithinOneMonth, I have the following test result:
[Test Description] isLowestWithinOneMonth for Apple
[Observed Error] org.scalatest.exceptions.TestFailedException: List(2000-01-03, 2000-01-04, 2000-01-06, 2000-01-11, 2000-01-12) did not equal List(2000-01-03, 2000-01-04, 2000-01-06, 2000-01-11, 2000-01-12, 2000-02-25, 2000-02-28)
[exception was thrown] detailed error message in debug output section below
[Lost Points] 1

However, when checking the data, 2000-02-25 (3.941964) shouldn't be in that list because it is not the lowest within one month.
The closing value on 2000-02-11 (3.883929) was obviously lower but it wasn't low enough to be below 2000-01-12 (3.113839) which was in the 30 day frame of the 11th. And for the 28th, I have no idea why that one is even in the list. It's value of 4.044643 is even higher than the 25th.
Could you clarify why they should be in the list?

Best,
Stefan

Re: Ex 7 Grading Lowest Within One Month

Verfasst: 9. Jan 2018 13:20
von meichholz
Hi,

you are absolutely right, this doesn't really make sense... I'll let you know as soon as I have updated the solution and the grades are updated.

Best,
Matthias

Re: Ex 7 Grading Lowest Within One Month

Verfasst: 15. Jan 2018 20:39
von Stefan94
Hey,

I assume you changed it because now it says:
[Test Description] isLowestWithinOneMonth: Test all dates with lowest prices for Apple after 60 days
[Observed Error] org.scalatest.exceptions.TestFailedException: List(2000-01-03, 2000-01-04, 2000-01-06, 2000-01-11, 2000-01-12) did not equal List(2000-01-03, 2000-01-04, 2000-01-06, 2000-01-11, 2000-01-12, 2000-01-13, 2000-02-02)
[exception was thrown] detailed error message in debug output section below
[Lost Points] 1

However, it still looks wrong considering that the 13th is higher than the 12th and the 02nd is also higher than the 12th.
I assume you changed it to have the lowest of 30 days in its list but the signal is always about the current date and while the 13th might be the lowest within the 30 day window starting on the 13th, it is not when it's actually the 13th.

Best,
Stefan

Re: Ex 7 Grading Lowest Within One Month

Verfasst: 21. Jan 2018 13:05
von Stefan94
Any comment on this?

Re: Ex 7 Grading Lowest Within One Month

Verfasst: 22. Jan 2018 10:33
von meichholz
Hi,

you're right... the current solution implements the lowest within a 30 days window, which is different from what the task demands.

Best,
Matthias

Re: Ex 7 Grading Lowest Within One Month

Verfasst: 30. Jan 2018 00:18
von Stefan94
Did you update this yet? Because my grading hasn't changed.

Re: Ex 7 Grading Lowest Within One Month

Verfasst: 30. Jan 2018 09:36
von meichholz
Hi,

not yet, however, I just fixed the sample solution and will run the grading later again.

For the first 120 days, the isLowestWithinOneMonth event for Apple should fire on the following dates:

Code: Alles auswählen

List(2000-01-03, 2000-01-04, 2000-01-06, 2000-01-11, 2000-01-12, 2000-04-12)
Any objections?

Best,
Matthias

Re: Ex 7 Grading Lowest Within One Month

Verfasst: 1. Feb 2018 21:32
von Stefan94
Looks good to me. Can't verify the april one right now but the rest is definitely correct.

Re: Ex 7 Grading Lowest Within One Month

Verfasst: 7. Feb 2018 23:22
von Stefan94
I've tried to send you a mail but I guess it didn't work.
Didn't want to revive this but for me the tests where updated (it says everything was okay) but the grading didn't update.
Isn't that big of a difference but would be nice if you could look into that.

Best,
Stefan

Re: Ex 7 Grading Lowest Within One Month

Verfasst: 8. Feb 2018 15:07
von meichholz
Hi,

I've received you email. Unfortunately, I was very busy this week and didn't have time to answer you yet. I'll have a look at your submission later.

Best,
Matthias